Standard protection vs end-to-end
Apple encrypts iCloud data by two models. Under standard data protection, categories like iCloud Photos are encrypted, but Apple holds the encryption keys — which is what lets them help with account recovery, and also means the data can be accessed on Apple's side. End-to-end encrypted categories can only be read by your trusted devices.
By default, iCloud Photos uses standard protection. That's fine against most threats, but it isn't 'only you can see it'.
What Advanced Data Protection does
Advanced Data Protection (ADP), which you can turn on in Settings, extends end-to-end encryption to more categories — including iCloud Photos. With ADP on, the keys stay on your devices, Apple can't access the contents, and you become responsible for recovery (via a recovery key or contact).
Where a vault fits
ADP protects your whole iCloud Photos library end-to-end. A separate on-device vault is a different tool: it keeps specific photos out of the Photos library (and so out of iCloud Photos entirely) behind their own code. Use ADP for your library, and a vault for the handful of things you want separately locked and off the cloud.